further improvements to create/edit alerts

rowers/alerts.py

@@ -38,16 +38,17 @@ def create_alert(manager, rower, measured,period=7, emailalert=True,
     if 'filter' in kwargs:
         filters = kwargs['filter']
         for f in filters:
-            m = Condition(
-                metric = f['metric'],
-                value1 = f['value1'],
-                value2 = f['value2'],
-                condition = f['condition']
+            if f['metric'] and f['condition']:
+                m = Condition(
+                    metric = f['metric'],
+                    value1 = f['value1'],
+                    value2 = f['value2'],
+                    condition = f['condition']
                 )
+                
+                m.save()
 
-            m.save()
-
-            alert.filter.add(m)
+                alert.filter.add(m)
 
 
     return alert.id,'Your alert was created'