From e328bc38fd8bf3304d1aeb181a5b6fa7690d477c Mon Sep 17 00:00:00 2001 From: Sander Roosendaal Date: Thu, 29 Feb 2024 19:17:27 +0100 Subject: [PATCH] expanding tests a bit --- rowers/tests/test_aworkouts.py | 15 ++++++++++++++- rowers/tests/testdata/testdata.tcx.gz | Bin 3999 -> 4000 bytes rowers/views/workoutviews.py | 8 ++++---- 3 files changed, 18 insertions(+), 5 deletions(-) diff --git a/rowers/tests/test_aworkouts.py b/rowers/tests/test_aworkouts.py index 06da2171..595f0148 100644 --- a/rowers/tests/test_aworkouts.py +++ b/rowers/tests/test_aworkouts.py @@ -117,10 +117,23 @@ class ListWorkoutTest(TestCase): form_data = { 'workouts': ['1','2'], - 'action': ['remove'], + 'action': ['export'], + 'destination': 'strava', } response = self.c.post(expected_url, form_data, follow=True) + url = expected_url + expected_url = reverse('workouts_view') + self.assertRedirects(response, + expected_url=expected_url, + status_code=302, + target_status_code=200) + form_data = { + 'workouts': ['1','2'], + 'action': ['remove'], + } + + response = self.c.post(url, form_data, follow=True) expected_url = reverse('workouts_view') self.assertRedirects(response, expected_url=expected_url, diff --git a/rowers/tests/testdata/testdata.tcx.gz b/rowers/tests/testdata/testdata.tcx.gz index 23bd61cc089d063670e638aa199f6f6e33b8fc30..f67f2da08debcff3873da3041d8086f2cfd88f25 100644 GIT binary patch delta 257 zcmV+c0sj7O}Bp8ot$i+R{FSFAHVGSE}ggAyRK|D;Q1XTfpR&tLDh zTBprkKJB;NaQSGzIRC-(bkm2wEl-x+W|=tTPahuLmHRq)+^vrvJv{v7X=bzibGQB1 z^cFvTefnaV?hN1ufZhKGiz{F3p8WPP9p2fZUaiw}c#u#oFCM0+@giON@Xr4LkP83& H#DD<+XIYPr delta 256 zcmV+b0ssD>AD9~XYulrYL7gt`B z`{(B;tD~+@KmGE>xIFh)CrjV`{Cair^77~Yp5DiF=#_`_Vat>5Kk1U$S#WUm^Vhqr z)@iesPy1~*Tt3<_&VTSc-Spva%adidStbto(}zcQ<-QIcckAOv4-bENn%Qjs+-?6g zy~R&opT1b8I|KLuVE6yQ;>s7hC%=76hj+H9SL^f~9wd~@i-+lHyhxWmyz@V2ZSMla GfB^uzdXM4& diff --git a/rowers/views/workoutviews.py b/rowers/views/workoutviews.py index 32bf82cf..83fbcadd 100644 --- a/rowers/views/workoutviews.py +++ b/rowers/views/workoutviews.py @@ -2048,9 +2048,9 @@ def workouts_bulk_actions(request): w = get_workout_by_opaqueid(request, encid) if w.user == r: workouts.append(w) - else: + else: # pragma: no cover messages.error(request,'Bulk actions are not accessible to coaches') - except KeyError: + except KeyError: # pragma: no cover pass if request.method == 'POST': @@ -2058,7 +2058,7 @@ def workouts_bulk_actions(request): form = WorkoutMultipleCompareForm(request.POST) if form.is_valid() and actionform.is_valid(): workouts = form.cleaned_data['workouts'] - if len(workouts) == 0: + if len(workouts) == 0: # pragma: no cover url = reverse('workouts_view') return HttpResponseRedirect(url) action = actionform.cleaned_data['action'] @@ -2078,7 +2078,7 @@ def workouts_bulk_actions(request): 'Workout {id} exported to {destination}'.format( id=encoder.encode_hex(w.id), destination=destination)) - except NoTokenError: + except NoTokenError: # pragma: no cover messages.error(request, 'Export to {destination} of workout {id} failed'.format( id=encoder.encode_hex(w.id),