Merge branch 'feature/uximprovements' into develop

rowers/models.py

@@ -945,6 +945,7 @@ class TrainingTarget(models.Model):
     def __unicode__(self):
         date = self.date
         name = self.name
+        id = self.pk
         try:
             ownerfirst = self.manager.user.first_name
             ownerlast = self.manager.user.last_name
@@ -952,11 +953,12 @@ class TrainingTarget(models.Model):
             ownerfirst = ''
             ownerlast = ''
 
-        stri = u'{ownerfirst} {ownerlast} {d} {n}'.format(
+        stri = u'#{id}: {n} {d} {ownerfirst} {ownerlast}'.format(
             ownerfirst = ownerfirst,
             ownerlast = ownerlast,
             d = date.strftime('%Y-%m-%d'),
-            n = name
+            n = name,
+            id = id,
             )
 
         return stri
@@ -1099,6 +1101,12 @@ class TrainingPlanForm(ModelForm):
             targetchoices = [(x.id,x) for x in targets]
             targetchoices.append((None,'---'))
             self.fields['target'].choices = targetchoices
+        elif self.instance.pk is not None:
+            self.fields['target'].queryset = TrainingTarget.objects.filter(
+                manager=self.instance.manager,
+                date__gte=datetime.date.today()).order_by("date")
+        else:
+            self.fields.pop('target')
 
         try:
             teams = Team.objects.filter(manager=self.instance.manager.user)

rowers/templates/trainingplan.html

@@ -70,6 +70,13 @@
                   {{ macrocycle.0.name }} ({{ macrocycle.0.startdate }} - {{ macrocycle.0.enddate }})
                 </th>
               </tr>
+              {% if macrocycle.0.notes %}
+              <tr>
+                <td colspan="4">
+                  {{ macrocycle.0.notes|linebreaks }}
+                </td>
+              </tr>
+              {% endif %}
               {% if macrocycle.0.type == 'userdefined' and macrocycle.0.plan.status %}
               <tr>
                 <td></td>
@@ -180,6 +187,13 @@
                         Meso {{ mesocycle.0.name }} ({{ mesocycle.0.startdate }} - {{ mesocycle.0.enddate }})
                       </th>
                     </tr>
+                    {% if mesocycle.0.notes %}
+                    <tr>
+                      <td colspan="4">
+                        {{ mesocycle.0.notes|linebreaks }}
+                      </td>
+                    </tr>
+                    {% endif %}
                     {% if mesocycle.0.type == 'userdefined' and mesocycle.0.plan.plan.status  %}
                     <tr>
                       <td></td>
@@ -299,6 +313,13 @@
                             Micro {{ microcycle.name }} ({{ microcycle.startdate }} - {{ microcycle.enddate }})
                           </th>
                         </tr>
+                        {% if microcycle.notes %}
+                        <tr>
+                          <td colspan="4">
+                            {{ microcycle.notes|linebreaks }}
+                          </td>
+                        </tr>
+                        {% endif %}
                         {%  if microcycle.plan.plan.plan.status %}
                         <tr>
                           <td></td>

rowers/templatetags/rowerfilters.py

@@ -397,9 +397,12 @@ def timeurl(path,timestring):
 
 @register.filter
 def trainingplans(rower):
+    today = datetime.date.today()
     plans = TrainingPlan.objects.filter(
         rowers=rower,
-        status=True).order_by("-startdate")
+        status=True,
+        startdate__lte=today,
+        enddate__gte=today).order_by("-startdate")
 
     return plans
 

rowers/views.py

@@ -16188,7 +16188,10 @@ def rower_create_trainingplan(request,userid=0):
             p.rowers.add(therower)
 
         
-    targets = TrainingTarget.objects.filter(rowers=therower).order_by("date")
+    targets = TrainingTarget.objects.filter(
+        rowers=therower,
+        date__gte=datetime.date.today(),
+    ).order_by("date")
     targetform = TrainingTargetForm()
     
     plans = TrainingPlan.objects.filter(rowers=therower).order_by("-startdate")
@@ -17008,6 +17011,8 @@ class TrainingPlanUpdate(UpdateView):
         obj = super(TrainingPlanUpdate, self).get_object(*args, **kwargs)
         if obj.manager is not None and self.request.user.rower != obj.manager:
             raise PermissionDenied('You are not allowed to edit this training plan cycle')
+        if obj.manager.rowerplan not in ['coach','plan']:
+            raise PermissionDenied('You are not allowed to edit this training plan')
             
         return obj