sander/rowsandall
Private
Public Access
1
0
Fork 0
Code Activity

Increasing coverage

Browse Source
This commit is contained in:
Sander Roosendaal
2024-03-01 12:26:36 +01:00
parent eb33bd9a8a
commit c4426d8a0b
12 changed files with 226 additions and 85 deletions
Download Patch File Download Diff File Expand all files Collapse all files

47
rowers/views/analysisviews.py
View File

@@ -56,7 +56,7 @@ def analysis_new(request,
try:
thesession = PlannedSession.objects.get(id=session)
if not can_view_session(user, thesession):
if not can_view_session(user, thesession): # pragma: no cover
raise PermissionDenied("you cannot view this session")
except PlannedSession.DoesNotExist:
thesession = None
@@ -102,7 +102,7 @@ def analysis_new(request,
try:
waterboattype = options['waterboattype']
except KeyError:
except KeyError: # pragma: no cover
pass
if request.method == 'POST':
@@ -188,7 +188,7 @@ def analysis_new(request,
pass
rankingtypes = [False,True]
if ranking:
if ranking: # pragma: no cover
rankingtypes = [True]
@@ -272,7 +272,7 @@ def analysis_new(request,
request.session['options'] = options
savedata = options.get('savedata',False)
if savedata:
if savedata: # pragma: no cover
ids = options.get('ids',[])
tw = []
for id in ids:
@@ -526,7 +526,7 @@ def trendflexdata(workouts, options, userid=0):
extratitle = ' '+u.first_name+' '+u.last_name
savedata = options.get('savedata',False)
if savedata:
if savedata: # pragma: no cover
return df
script, div = interactive_multiflex(df, xparam, yparam,
@@ -561,7 +561,7 @@ def flexalldata(workouts, options):
extratitle = ' '+u.first_name+' '+u.last_name
savedata = options.get('savedata',False)
if savedata:
if savedata: # pragma: no cover
workstrokesonly = not includereststrokes
columns = [xparam, yparam1, yparam2, 'spm', 'driveenergy', 'distance']
ids = [int(w.id) for w in workouts]
@@ -603,7 +603,7 @@ def histodata(workouts, options):
extratitle = ' '+u.first_name+' '+u.last_name
savedata = options.get('savedata',False)
if savedata:
if savedata: # pragma: no cover
workstrokesonly = not includereststrokes
ids = [int(w.id) for w in workouts]
df = dataprep.getsmallrowdata_db([plotfield], ids=ids,
@@ -640,7 +640,7 @@ def cpdata(workouts, options):
})
savedata = options.get('savedata',False)
if savedata:
if savedata: # pragma: no cover
return powerdf
if powerdf.empty: # pragma: no cover
@@ -869,7 +869,7 @@ def comparisondata(workouts, options):
}
savedata = options.get('savedata',False)
if savedata:
if savedata: # pragma: no cover
workstrokesonly = not includereststrokes
columns = [xparam, yparam1,
'ftime', 'distance', 'fpace',
@@ -950,7 +950,7 @@ def boxplotdata(workouts, options):
extratitle = ' '+u.first_name+' '+u.last_name
savedata = options.get('savedata',False)
if savedata:
if savedata: # pragma: no cover
return datadf
script, div = interactive_boxchart(datadf, plotfield,
@@ -1425,7 +1425,7 @@ def rankings_view2(request, userid=0,
wcdurations = options['wcdurations']
wcpower = options['wcpower']
lastupdated = options['lastupdated']
except KeyError:
except KeyError: # pragma: no cover
pass
try:
userid = options['userid']
@@ -2017,7 +2017,7 @@ class ForceCurveAnalysisDelete(DeleteView):
def get_object(self, *args, **kwargs):
obj = super(ForceCurveAnalysisDelete, self).get_object(*args, **kwargs)
if obj.rower != self.request.user.rower:
if obj.rower != self.request.user.rower: # pragma: no cover
raise PermissionDenied("You are not allowed to delete this Analysis")
return obj
@@ -2039,8 +2039,7 @@ class SavedAnalysisView(UserPassesTestMixin, View):
analyses = None
chart = instroke_multi_interactive_chart
def handle_no_permission(self):
def handle_no_permission(self): # pragma: no cover
if self.request.user.is_anonymous:
url = reverse('login')+'?next='+self.request.path
return HttpResponseRedirect(url)
@@ -2079,7 +2078,7 @@ class SavedAnalysisView(UserPassesTestMixin, View):
super(SavedAnalysisView, self).setup(request, *args, **kwargs)
self.r = getrequestrower(request, userid=self.userid)
if self.r is not None and not is_coach_user(self.request.user, self.r.user):
if self.r is not None and not is_coach_user(self.request.user, self.r.user): # pragma: no cover
raise PermissionDenied("You are not allowed to see analyses for this user")
self.analyses = self.analysis_class.objects.filter(rower=self.r).order_by("-date","-id")
@@ -2087,7 +2086,7 @@ class SavedAnalysisView(UserPassesTestMixin, View):
startdate = request.GET.get('startdate')
enddate = request.GET.get('enddate')
self.searchform = SearchForm()
if query:
if query: # pragma: no cover
query_list = query.split()
if self.analysis_class == InStrokeAnalysis:
self.analyses = self.analyses.filter(
@@ -2111,13 +2110,13 @@ class SavedAnalysisView(UserPassesTestMixin, View):
)
self.searchform = SearchForm(initial={'q': query})
date_initial = {}
if startdate:
if startdate: # pragma: no cover
try:
self.analyses = self.analyses.filter(date__gte=startdate)
date_initial['startdate'] = startdate
except ValidationError:
messages.error(request,"{startdate} is not a valid start date".format(startdate=startdate))
if enddate:
if enddate: # pragma: no cover
self.analyses = self.analyses.filter(date__lte=enddate)
date_initial['enddate'] = enddate
self.dateform = DateRangeForm(initial=date_initial)
@@ -2136,7 +2135,7 @@ class SavedAnalysisView(UserPassesTestMixin, View):
'dateform': self.dateform,
})
def post(self, request, *args, **kwargs):
def post(self, request, *args, **kwargs): # pragma: no cover
form = self.form_class(request.POST)
if form.is_valid():
@@ -2211,7 +2210,7 @@ class InStrokeAnalysisDelete(DeleteView):
def get_object(self, *args, **kwargs):
obj = super(InStrokeAnalysisDelete, self).get_object(*args, **kwargs)
if obj.rower != self.request.user.rower:
if obj.rower != self.request.user.rower: # pragma: no cover
raise PermissionDenied("You are not allowed to delete this Analysis")
return obj
@@ -2356,7 +2355,7 @@ def alert_report_view(request, id=0, userid=0, nperiod=0):
stats = alert_get_stats(alert, nperiod=nperiod)
is_ajax = request_is_ajax(request)
if is_ajax:
if is_ajax: # pragma: no cover
return JSONResponse({
"stats": stats,
})
@@ -2772,7 +2771,7 @@ def history_view_data(request, userid=0):
df = getsmallrowdata_db(columns, ids=ids)
try:
df['deltat'] = df['time'].diff().clip(lower=0)
except KeyError:
except KeyError: # pragma: no cover
pass
df = dataprep.clean_df_stats(df, workstrokesonly=True,
ignoreadvanced=True, ignorehr=False)
@@ -2825,7 +2824,7 @@ def history_view_data(request, userid=0):
ddict['powermean'] = int(wavg(ddf, 'power', 'deltat'))
try:
ddict['powermax'] = ddf['power'].max().astype(int)
except KeyError:
except KeyError: # pragma: no cover
ddict['powermax'] = 0
ddict['nrworkouts'] = a_workouts.count()
listofdicts.append(ddict)
@@ -2840,7 +2839,7 @@ def history_view_data(request, userid=0):
try:
totalsdict['powermean'] = int(wavg(df, 'power', 'deltat'))
totalsdict['powermax'] = df['power'].max().astype(int)
except KeyError:
except KeyError: # pragma: no cover
totalsdict['powermean'] = 0
totalsdict['powermax'] = 0
try:

32
rowers/views/importviews.py
View File

@@ -41,7 +41,7 @@ def workout_export_view(request, id=0, source='c2'):
integration = importsources[source](request.user)
try:
id = integration.workout_export(w)
except NoTokenError:
except NoTokenError: # pragma: no cover
return HttpResponseRedirect(integration.make_authorization_url())
messages.info(
@@ -73,7 +73,7 @@ def rower_rojabo_authorize(request): # pragma: no cover
return HttpResponseRedirect(url)
@login_required()
def rower_integration_authorize(request, source='c2'):
def rower_integration_authorize(request, source='c2'): # pragma: no cover
try:
integration = importsources[source](request.user)
except KeyError:
@@ -107,7 +107,7 @@ def rower_polar_authorize(request, source='polar'): # pragma: no cover
def rower_integration_token_refresh(request, source='c2'):
try:
integration = importsources[source](request.user)
except KeyError:
except KeyError: # pragma: no cover
url = reverse('workouts_view')
return HttpResponseRedirect(url)
try:
@@ -217,7 +217,7 @@ def rower_process_polarcallback(request):
try:
error = polar_user_data['error']
if error['error_type'] == 'user_already_registered':
if error['error_type'] == 'user_already_registered': # pragma: no cover
s = error['message']
tester = re.compile(r'.*userid:(?P<id>\d+)')
testresult = tester.match(s)
@@ -371,7 +371,7 @@ def workout_import_view(request, source='c2'):
r = getrequestrower(request)
try:
integration = importsources[source](request.user)
except KeyError:
except KeyError: # pragma: no cover
messages.error(request,"This integration is not supported")
url = reverse('workouts_view')
return HttpResponseRedirect(url)
@@ -428,7 +428,7 @@ def workout_import_view(request, source='c2'):
startdate=startdate,
enddate=enddate
)
except NoTokenError:
except NoTokenError: # pragma: no cover
messages.error(request,"You must first make the connection to {source}".format(
source=source
))
@@ -504,7 +504,7 @@ def rower_process_stravacallback(request):
try:
res = strava_integration.get_token(code,logfile='strava_log.log')
except NoTokenError:
except NoTokenError: # pragma: no cover
message = "Something went wrong with the Strava authorization"
messages.error(request, message)
url = reverse('rower_exportsettings_view')
@@ -526,7 +526,7 @@ def rower_process_stravacallback(request):
r.save()
try:
_ = strava_integration.set_strava_athlete_id()
except NoTokenError:
except NoTokenError: # pragma: no cover
messages.error(request,'Something went wrong storing your Strava ID. Please authorize again')
url = reverse('rower_exportsettings_view')
return HttpResponseRedirect(url)
@@ -540,7 +540,7 @@ def rower_process_stravacallback(request):
messages.error(request, message)
url = reverse('rower_exportsettings_view')
return HttpResponseRedirect(url)
return HttpResponseRedirect(url) # pragma: no cover
# Process SportTracks callback
@@ -653,7 +653,7 @@ def rower_process_testcallback(request): # pragma: no cover
message="This functionality requires a Pro plan or higher",
redirect_field_name=None)
@permission_required('rower.is_coach', fn=get_user_by_userid, raise_exception=True)
def workout_rojaboimport_view(request, message="", userid=0):
def workout_rojaboimport_view(request, message="", userid=0): # pragma: no cover
r = getrequestrower(request, userid=userid)
if r.user != request.user:
messages.error(
@@ -728,21 +728,21 @@ def workout_rojaboimport_view(request, message="", userid=0):
item['warm_up']['steps'],
warmup=True
)
except KeyError:
except KeyError: # pragma: no cover
pass
try:
steps = steps + rojabo_stuff.stepsconvert(
item['primary']['steps'],
startid=len(steps)
)
except KeyError:
except KeyError: # pragma: no cover
pass
try:
steps = steps + rojabo_stuff.stepsconvert(
item['cool_down']['steps'],
cooldown=True,
startid=len(steps))
except KeyError:
except KeyError: # pragma: no cover
pass
if steps:
@@ -755,7 +755,7 @@ def workout_rojaboimport_view(request, message="", userid=0):
ps.save()
messages.info(request,'Saved planned session {id}'.format(id=ps.id))
except KeyError:
except KeyError: # pragma: no cover
pass
except KeyError:
pass
@@ -1019,7 +1019,7 @@ def garmin_details_view(request):
def workout_getimportview(request, externalid, source='c2', do_async=True):
try:
integration = importsources[source](request.user)
except (TypeError, NotImplementedError, KeyError):
except (TypeError, NotImplementedError, KeyError): # pragma: no cover
return reverse("workouts_view")
if 'startdate' in request.session and source == 'nk': # pragma: no cover
startdate = request.session.get('startdate')
@@ -1051,7 +1051,7 @@ def workout_getimportview(request, externalid, source='c2', do_async=True):
# Imports all new workouts from SportTracks
@login_required()
def workout_getsporttracksworkout_all(request):
def workout_getsporttracksworkout_all(request): # pragma: no cover
st_integration = importsources['sporttracks'](request.user)
try:
_ = st_integration.get_workouts()

14
rowers/views/userviews.py
View File

@@ -258,7 +258,7 @@ def user_messages(request,userid=0):
'rower':r})
@login_required()
def user_message_delete(request,id=0):
def user_message_delete(request,id=0): # pragma: no cover
try:
msg = UserMessage.objects.get(id=id)
except UserMessage.DoesNotExist:
@@ -278,7 +278,7 @@ def user_message_delete(request,id=0):
@login_required()
def user_message_markread(request,id=0):
def user_message_markread(request,id=0): # pragma: no cover
try:
msg = UserMessage.objects.get(id=id)
except UserMessage.DoesNotExist:
@@ -448,13 +448,13 @@ def rower_exportsettings_view(request, userid=0):
if not user_is_not_basic(r.user): # pragma: no cover
if not user_is_coachee(r.user):
doset = False
if not doset:
if not doset: # pragma: no cover
before = getattr(r, attr)
if before == value:
doset = True
if doset:
setattr(r, attr, value)
else:
else: # pragma: no cover
if user_is_not_basic(r.user):
messages.error(
request, 'Could not set '+attr+'. You need to create the connection first.')
@@ -605,7 +605,7 @@ def rower_simpleprefs_view(request, userid=0):
r = getrequestrowercoachee(request, userid=userid, notpermanent=True)
firsttime = False
if not r.ftpset:
if not r.ftpset: # pragma: no cover
r.ftpset = True
r.save()
firsttime = True
@@ -623,7 +623,7 @@ def rower_simpleprefs_view(request, userid=0):
form = SimpleRowerPowerForm(instance=r)
if request.method == 'POST':
if request.method == 'POST': # pragma: no cover
form = SimpleRowerPowerForm(request.POST, instance=r)
if form.is_valid():
form.save(commit=True)
@@ -714,7 +714,7 @@ def rower_prefs_view(request, userid=0, message=""):
r.pw_ut1,
r.pw_at,
r.pw_tr, r.pw_an])/r.ftp
if cogganzones:
if cogganzones: # pragma: no cover
powerfrac = np.array([55.,75.,90.,105.,120.])
powerzones = ['Rest',
'Active Recovery',

2
rowers/views/workoutviews.py
View File

@@ -3299,7 +3299,6 @@ def instroke_chart_interactive(request, id=0, analysis=0, userid=0):
rowdata = rrdata(csvfile=w.csvfilename)
instrokemetrics = rowdata.get_instroke_columns()
form = InstrokeForm(choices=instrokemetrics)
breadcrumbs = [
@@ -3513,6 +3512,7 @@ def instroke_chart_interactive(request, id=0, analysis=0, userid=0):
name=name,notes=notes,
)
# change to range spm_min to spm_max
vals, units, typ = rowdata.updateinterval_range(
' Cadence (stokes/min)', spm_min, spm_max,