diff --git a/rowers/models.py b/rowers/models.py index 91abb9b4..6590aa57 100644 --- a/rowers/models.py +++ b/rowers/models.py @@ -1351,7 +1351,7 @@ class TrainingPlan(models.Model): def save(self, *args, **kwargs): manager = self.manager - if not can_add_plan(manager): + if not can_add_plan(manager.user): raise ValidationError( "Basic user cannot have a training plan" ) diff --git a/rowers/rower_rules.py b/rowers/rower_rules.py index c4e58792..5de0d339 100644 --- a/rowers/rower_rules.py +++ b/rowers/rower_rules.py @@ -86,7 +86,7 @@ def user_is_not_basic(user): def is_coach(user): return user.rower.rowerplan in ['coach','freecoach'] -def is_paidcoach(user): +def is_paid_coach(user): return user.rower.rowerplan == 'coach' @rules.predicate @@ -228,6 +228,9 @@ def can_add_workout_member(user,rower): # check if user can plan for the rower @rules.predicate def can_plan_user(user,rower): + if not isplanmember(user): + return False + try: r = user.rower except AttributeError: @@ -243,7 +246,7 @@ def can_plan_user(user,rower): return False -rules.add_perm('rower.can_plan',can_plan_user) # replaces checkaccessplanuser +rules.add_perm('rower.add_plan',can_plan_user) # replaces checkaccessplanuser rules.add_perm('rower.is_coach',is_coach_user) # replaces checkaccessuser rules.add_perm('rower.is_pro',ispromember) diff --git a/rowers/teams.py b/rowers/teams.py index 9aa98b68..aa1c8903 100644 --- a/rowers/teams.py +++ b/rowers/teams.py @@ -173,12 +173,15 @@ def rower_get_coaches(rower): def coach_getcoachees(coach): + rowers = [] if coach.mycoachgroup and is_coach(coach.user): - return Rower.objects.filter( + rs = Rower.objects.filter( coachinggroups__in=[coach.mycoachgroup] ).distinct().order_by("user__last_name","user__first_name") - else: - return [] + for r in rs: + rowers.append(r) + + return rowers def coach_remove_athlete(coach,rower): try: diff --git a/rowers/templates/menu_other.html b/rowers/templates/menu_other.html index fad56ed0..a3961006 100644 --- a/rowers/templates/menu_other.html +++ b/rowers/templates/menu_other.html @@ -14,7 +14,7 @@ {% else %}  Compare {% endif %} - +
  •  Upload
  • @@ -33,7 +33,7 @@
  • - + - - {% include 'menuscript.html' %} diff --git a/rowers/templates/menu_profile.html b/rowers/templates/menu_profile.html index bdeb6f54..05cf98f1 100644 --- a/rowers/templates/menu_profile.html +++ b/rowers/templates/menu_profile.html @@ -44,13 +44,13 @@ {% if user.is_authenticated and user|is_manager and rower %}

     

    -{% if user|coach_rowers %} +{% if request.user|coach_rowers %}