From 7d54faf38a7595c690f90ca9375ae733ac640868 Mon Sep 17 00:00:00 2001 From: Sander Roosendaal Date: Mon, 20 Jan 2020 17:08:32 +0100 Subject: [PATCH] small improvement in permissions tests --- rowers/tests/test_permissions2.py | 29 ++++++++++++++++++----------- 1 file changed, 18 insertions(+), 11 deletions(-) diff --git a/rowers/tests/test_permissions2.py b/rowers/tests/test_permissions2.py index e9c6c14a..7c99c220 100644 --- a/rowers/tests/test_permissions2.py +++ b/rowers/tests/test_permissions2.py @@ -221,6 +221,7 @@ class PermissionsViewTests(TestCase): if permissions['own'] and not permissions['is_staff']: urlstotest = [] falseurlstotest = [] + permissiondeniedtests = [] if permissions['own'] == 'basic': thisuser = self.ubasic notuser = None @@ -246,18 +247,24 @@ class PermissionsViewTests(TestCase): elif permissions['userid']: url = reverse(view,kwargs={'userid':thisuser['user'].id}) urlstotest.append(url) - if notuser: - url = reverse(view,kwargs={'userid':self.ustrange['user'].id}) - falseurlstotest.append(url) + + url = reverse(view,kwargs={'userid':self.ustrange['user'].id}) + permissiondeniedtests.append(url) for url in urlstotest: - print(url) - login = self.c.login(username = thisuser['username'],password = thisuser['password']) - result = self.c.get(url) - self.assertEqual(result.status_code, permissions['own_response']) + print(url) + login = self.c.login(username = thisuser['username'],password = thisuser['password']) + result = self.c.get(url) + self.assertEqual(result.status_code, permissions['own_response']) for url in falseurlstotest: - print(url) - login = self.c.login(username = notuser['username'],password = notuser['password']) - result = self.c.get(url) - self.assertEqual(result.status_code, permissions['own_nonperm']) + print(url) + login = self.c.login(username = notuser['username'],password = notuser['password']) + result = self.c.get(url) + self.assertEqual(result.status_code, permissions['own_nonperm']) + + for url in permissiondeniedtests: + print(url) + login = self.c.login(username = thisuser['username'],password = thisuser['password']) + result = self.c.get(url) + self.assertEqual(result.status_code,404)