From 232c144efa9c7aa9423e8210111cf446b72078bc Mon Sep 17 00:00:00 2001
From: Sander Roosendaal <roosendaalsander@gmail.com>
Date: Fri, 5 Mar 2021 17:58:18 +0100
Subject: [PATCH 1/3] small UI improvements planned session

---
 rowers/templates/plannedsessions.html | 10 ++++++++++
 rowers/views/planviews.py             | 21 +++++++++++++++------
 2 files changed, 25 insertions(+), 6 deletions(-)

diff --git a/rowers/templates/plannedsessions.html b/rowers/templates/plannedsessions.html
index 1b583cc6..7a5f6261 100644
--- a/rowers/templates/plannedsessions.html
+++ b/rowers/templates/plannedsessions.html
@@ -8,6 +8,16 @@
 
 <h1>Planned Sessions for {{ rower.user.first_name }} {{ rower.user.last_name }}</h1>
 
+<p>
+	<a href="/rowers/sessions/create/?when={{ timeperiod }}">  <i class="far fa-calendar-plus fa-fw"></i>&nbsp;Add Session
+	</a>
+	{% if request.user|user_teams %}
+	<a href="/rowers/sessions/teamcreate/?when={{ timeperiod }}">
+		<i class="fas fa-whistle fa-fw"></i>&nbsp;Add Group Session
+	</a>
+{% endif %}
+</p>
+
 <ul class="main-content">
   <li class="grid_2">
     <p>
diff --git a/rowers/views/planviews.py b/rowers/views/planviews.py
index f9b4e29c..7497d901 100644
--- a/rowers/views/planviews.py
+++ b/rowers/views/planviews.py
@@ -531,6 +531,11 @@ def plannedsession_create_view(request,
             request.session['fenddate'] = str(arrow.get(ps.enddate))
             request.session['fprefdate'] = str(arrow.get(ps.preferreddate))
 
+            url = reverse(plannedsessions_view,kwargs={
+                'userid':userid,
+            })
+            return HttpResponseRedirect(url)
+
     else:
         if 'fstartdate' in request.session:
             try:
@@ -921,15 +926,19 @@ def plannedsession_teamcreate_view(request,
                 for r in rs:
                     add_rower_session(r,ps)
 
+            url = reverse(plannedsessions_view,kwargs={
+                'userid':userid,
+            })
+            return HttpResponseRedirect(url)
 
-            url = reverse(plannedsession_teamcreate_view)
-            startdatestring = startdate.strftime('%Y-%m-%d')
-            enddatestring = enddate.strftime('%Y-%m-%d')
-            url += '?when='+startdatestring+'/'+enddatestring
+            #url = reverse(plannedsession_teamcreate_view)
+            #startdatestring = startdate.strftime('%Y-%m-%d')
+            #enddatestring = enddate.strftime('%Y-%m-%d')
+            #url += '?when='+startdatestring+'/'+enddatestring
 
-            next = request.GET.get('next', url)
+            #next = request.GET.get('next', url)
 
-            return HttpResponseRedirect(next)
+            #return HttpResponseRedirect(next)
         else:
             timeperiod = startdate.strftime('%Y-%m-%d')+'/'+enddate.strftime('%Y-%m-%d')
             breadcrumbs = [

From e02fec00ee1789d59534dac1615fe9ea7adf61dd Mon Sep 17 00:00:00 2001
From: Sander Roosendaal <roosendaalsander@gmail.com>
Date: Fri, 5 Mar 2021 18:27:33 +0100
Subject: [PATCH 2/3] updating tests to reflect new UI behavior

---
 rowers/tests/test_permissions.py | 14 +++++++++++---
 rowers/tests/test_plans.py       |  7 ++++++-
 2 files changed, 17 insertions(+), 4 deletions(-)

diff --git a/rowers/tests/test_permissions.py b/rowers/tests/test_permissions.py
index 76342ebb..df4c7980 100644
--- a/rowers/tests/test_permissions.py
+++ b/rowers/tests/test_permissions.py
@@ -740,8 +740,12 @@ class PermissionsViewTests(TestCase):
         form = PlannedSessionForm(post_data)
         self.assertTrue(form.is_valid())
 
+        expected_url = reverse('plannedsessions_view',kwargs={'userid':0})
+
         response = self.c.post(url,post_data)
-        self.assertEqual(response.status_code,200)
+        self.assertRedirects(response,
+                        expected_url=expected_url,
+                        status_code=302,target_status_code=200)
 
 
 
@@ -1118,8 +1122,12 @@ class PermissionsViewTests(TestCase):
         form = PlannedSessionForm(post_data)
         self.assertTrue(form.is_valid())
 
-        response = self.c.post(url,post_data)
-        self.assertEqual(response.status_code,200)
+        expected_url = reverse('plannedsessions_view',kwargs={'userid':0})
+
+        response = self.c.post(url,post_data,follow=True)
+        self.assertRedirects(response,
+                             expected_url=expected_url,
+                             status_code=302,target_status_code=200)
 
 
 
diff --git a/rowers/tests/test_plans.py b/rowers/tests/test_plans.py
index 9113c7ee..0eb63088 100644
--- a/rowers/tests/test_plans.py
+++ b/rowers/tests/test_plans.py
@@ -167,8 +167,13 @@ class TrainingPlanTest(TestCase):
             form = PlannedSessionForm(post_data)
             self.assertTrue(form.is_valid())
 
+            expected_url = reverse('plannedsessions_view',kwargs={'userid':0})
+
+
             response = self.c.post(url,post_data)
-            self.assertEqual(response.status_code,200)
+            self.assertRedirects(response,
+                            expected_url=expected_url,
+                            status_code=302,target_status_code=200)
 
 
 

From 35d97797c7c065746bfe1df3e091437b281b2fa0 Mon Sep 17 00:00:00 2001
From: Sander Roosendaal <roosendaalsander@gmail.com>
Date: Sat, 6 Mar 2021 16:13:46 +0100
Subject: [PATCH 3/3] fix

---
 rowers/utils.py | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/rowers/utils.py b/rowers/utils.py
index c12d71d5..72ce934f 100644
--- a/rowers/utils.py
+++ b/rowers/utils.py
@@ -901,7 +901,11 @@ def step_to_string(step):
 
         if value < 10 and value>0:
             target = 'Target: Power in zone {v}'.format(v=value)
-        else:
+        elif value > 10 and value < 1000:
+            target = 'Target: Power at {v} % of FTP'.format(v=value)
+        elif value > 1000:
+            target = 'Target: Power at {v} Watt'.format(v=value-1000)
+        elif valuelow > 0 and valuehigh > 0:
             if valuelow < 1000:
                 target = 'Target: Power between {l} and {h} % of FTP'.format(
                     l = valuelow,