From 3d9071fee1430d5f3844c40a246ae10dd4baad16 Mon Sep 17 00:00:00 2001 From: Sander Roosendaal Date: Sat, 13 Sep 2025 11:58:33 +0200 Subject: [PATCH] fixing auto export settings --- rowers/tests/testdata/testdata.tcx.gz | Bin 3989 -> 3989 bytes rowers/views/userviews.py | 24 +++--------------------- 2 files changed, 3 insertions(+), 21 deletions(-) diff --git a/rowers/tests/testdata/testdata.tcx.gz b/rowers/tests/testdata/testdata.tcx.gz index 9458f4e24543d6b78acbfb7ec56cd7f54b8a092c..b40a0d1218673194397206775c0ddb9df7b0b9d3 100644 GIT binary patch delta 16 XcmbO#KUJPxzMF$X)8Xhw_C9_9Cj|tp delta 16 XcmbO#KUJPxzMF$1<^H~n?0x(IEI9>$ diff --git a/rowers/views/userviews.py b/rowers/views/userviews.py index f4801527..f1015de2 100644 --- a/rowers/views/userviews.py +++ b/rowers/views/userviews.py @@ -463,7 +463,6 @@ def rower_favoritecharts_view(request, userid=0): @login_required() -@permission_required('rower.is_coach', fn=get_user_by_userid, raise_exception=True) def rower_exportsettings_view(request, userid=0): attrtokens = { 'polar_auto_import': 'polartoken', @@ -512,7 +511,6 @@ def rower_exportsettings_view(request, userid=0): if form.is_valid(): cd = form.cleaned_data for attr, value in cd.items(): - doset = True try: tokenname = attrtokens[attr] if (getattr(r, tokenname) == '' or getattr(r, tokenname) is None) and value: @@ -520,27 +518,11 @@ def rower_exportsettings_view(request, userid=0): request, 'Set '+attr+' but it will not be effective until you create a connection.' ) except KeyError: - doset = True - if not user_is_not_basic(r.user): # pragma: no cover - if not user_is_coachee(r.user): - doset = False - if not doset: # pragma: no cover - before = getattr(r, attr) - if before == value: - doset = True - if doset: - setattr(r, attr, value) - else: # pragma: no cover - if user_is_not_basic(r.user): - messages.error( - request, 'Could not set '+attr+'. You need to create the connection first.') - + pass + setattr(r, attr, value) r.save() - if doset: - messages.info(request, 'Settings saved') - else: # pragma: no cover - messages.error(request, 'Settings not saved: Need a Pro account') + messages.info(request, 'Settings saved') else: form = RowerExportForm(instance=r)