From 3357a06d4aeffa53a8fb69faf6d85232820103f3 Mon Sep 17 00:00:00 2001
From: Sander Roosendaal <roosendaalsander@gmail.com>
Date: Thu, 29 Aug 2019 07:47:02 +0200
Subject: [PATCH] improved privileges

---
 rowers/teams.py           |  4 ++--
 rowers/views/teamviews.py | 21 +++++++++------------
 2 files changed, 11 insertions(+), 14 deletions(-)

diff --git a/rowers/teams.py b/rowers/teams.py
index a11cbdae..4c8ee0a4 100644
--- a/rowers/teams.py
+++ b/rowers/teams.py
@@ -135,8 +135,8 @@ def add_member(id,rower):
     t= Team.objects.get(id=id)
     try:
         rower.team.add(t)
-    except ValidationError:
-        return(0,"Couldn't add member")
+    except ValidationError as e:
+        return(0,"Couldn't add member: "+str(e.message))
         
     # code to add all workouts
     ws = Workout.objects.filter(user=rower)
diff --git a/rowers/views/teamviews.py b/rowers/views/teamviews.py
index 8610beaa..fcf5b1e1 100644
--- a/rowers/views/teamviews.py
+++ b/rowers/views/teamviews.py
@@ -168,19 +168,22 @@ def get_teams(request):
         private='open').exclude(
             rower=r).exclude(manager=request.user).order_by('name')
 
+    if rower.rowerplan == 'basic':
+        otherteams.exclude(manager__rower__rowerplan='freecoach')
+
     return myteams, memberteams, otherteams
 
 @login_required()
-def rower_teams_view(request,message='',successmessage=''):
+def rower_teams_view(request):
     if request.method == 'POST':
         form = TeamInviteCodeForm(request.POST)
         if form.is_valid():
             code = form.cleaned_data['code']
             res,text = teams.process_invite_code(request.user,code)
             if res:
-                successmessage = text
+                messages.info(request,text)
             else:
-                message = text
+                messages.error(request,text)
     else:
         form = TeamInviteCodeForm()
             
@@ -249,8 +252,6 @@ def rower_teams_view(request,message='',successmessage=''):
     #    clubsize = teams.count_invites(request.user)+teams.count_club_members(request.user)
     #   max_clubsize = r.clubsize
 
-    messages.info(request,successmessage)
-    messages.error(request,message)
 
     breadcrumbs = [
         {
@@ -312,18 +313,14 @@ def manager_member_drop_view(request,teamid,userid,
     return HttpResponseRedirect(url)
 
 @login_required()
-def manager_requests_view(request,code=None,message='',successmessage=''):
+def manager_requests_view(request,code=None):
     if code:
         res,text = teams.process_request_code(request.user,code)
         if res:
-            successmessage = text
-            message = ''
+            messages.info(request,text)
         else:
-            message = text
-            successmessage = ''
+            messages.error(request,text)
 
-    messages.info(request,successmessage)
-    messages.error(request,message)
     url = reverse(rower_teams_view,kwargs={
     })
     return HttpResponseRedirect(url)