From 2d909edb110a005ce519f1706a384eff9617cf8d Mon Sep 17 00:00:00 2001 From: Sander Roosendaal Date: Fri, 7 Oct 2022 08:54:20 +0200 Subject: [PATCH] fix sticky setting of import settings by coach --- rowers/views/userviews.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/rowers/views/userviews.py b/rowers/views/userviews.py index 2a9601f9..90348d99 100644 --- a/rowers/views/userviews.py +++ b/rowers/views/userviews.py @@ -1,6 +1,6 @@ from rowers.views.statements import * -from rowers.rower_rules import user_is_not_basic +from rowers.rower_rules import user_is_not_basic, user_is_coachee @login_required() def deactivate_user(request): @@ -399,7 +399,8 @@ def rower_exportsettings_view(request, userid=0): except KeyError: doset = True if not user_is_not_basic(r.user): # pragma: no cover - doset = False + if not user_is_coachee(r.user): + doset = False if not doset: before = getattr(r, attr) if before == value: @@ -411,6 +412,7 @@ def rower_exportsettings_view(request, userid=0): messages.error( request, 'Could not set '+attr+'. You need to create the connection first.') + r.save() messages.info(request, 'Settings saved') else: