From 2fdcaedc7fc49d7a3845ab622c160cfb96141b93 Mon Sep 17 00:00:00 2001 From: Sander Roosendaal Date: Tue, 10 Jul 2018 12:52:53 +0200 Subject: [PATCH 1/4] fixed bug --- rowers/views.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rowers/views.py b/rowers/views.py index 58b0fac5..8e7e4718 100644 --- a/rowers/views.py +++ b/rowers/views.py @@ -9704,7 +9704,7 @@ def workout_getstravaworkout_all(request): newids = [stravaid for stravaid in stravaids if not stravaid in knownstravaids] for stravaid in newids: - res = stravastuff.get_strava_workout(request.user,stravaid) + res = stravastuff.get_workout(request.user,stravaid) strokedata = res[1] data = res[0] From 0a677bcbd83361853a85537c73ed0b26f4a2c2d5 Mon Sep 17 00:00:00 2001 From: Sander Roosendaal Date: Tue, 10 Jul 2018 14:11:22 +0200 Subject: [PATCH 2/4] code merge strava import all --- rowers/views.py | 37 ++++++------------------------------- 1 file changed, 6 insertions(+), 31 deletions(-) diff --git a/rowers/views.py b/rowers/views.py index 8e7e4718..d544c201 100644 --- a/rowers/views.py +++ b/rowers/views.py @@ -9694,37 +9694,12 @@ def workout_getsporttracksworkout_all(request): # Imports all new workouts from SportTracks @login_required() def workout_getstravaworkout_all(request): - res = stravastuff.get_strava_workout_list(request.user) - if (res.status_code == 200): - r = getrower(request.user) - stravaids = [int(item['id']) for item in res.json()] - knownstravaids = uniqify([ - w.uploadedtostrava for w in Workout.objects.filter(user=r) - ]) - newids = [stravaid for stravaid in stravaids if not stravaid in knownstravaids] - - for stravaid in newids: - res = stravastuff.get_workout(request.user,stravaid) - strokedata = res[1] - data = res[0] - - if data: - id,message = add_workout_from_strokedata( - request.user,stravaid,data,strokedata, - source='strava', - workoutsource='strava') - - if id==0: - messages.error(request,message) - - else: - messages.info(request,"imported Strava workout "+str(stravaid)) - w = Workout.objects.get(id=id) - w.uploadedtostrava=stravaid - w.save() - - else: - messages.error(request,"Couldn't import Strava workout "+str(stravaid)) + r = getrower(request.user) + res = stravastuff.get_strava_workouts(r) + if res == 1: + messages.info(request,"Your workouts are being imported and should appear on the site in the next 15 minutes") + else: + messages.error(request,"Couldn't import Strava workout "+str(stravaid)) url = reverse(workouts_view) return HttpResponseRedirect(url) From 08ca7539f27283f21374cc9a52ac462767fb0799 Mon Sep 17 00:00:00 2001 From: Sander Roosendaal Date: Tue, 10 Jul 2018 14:49:48 +0200 Subject: [PATCH 3/4] logout redirect improved --- rowsandall_app/settings.py | 1 + rowsandall_app/urls.py | 4 +++- templates/basebase.html | 2 +- 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/rowsandall_app/settings.py b/rowsandall_app/settings.py index 3ebb23d1..542b46ef 100644 --- a/rowsandall_app/settings.py +++ b/rowsandall_app/settings.py @@ -224,6 +224,7 @@ MEDIA_ROOT = os.path.join(BASE_DIR, 'media') LOGIN_REDIRECT_URL = '/rowers/list-workouts/' LOGIN_URL = '/login/' LOGOUT_URL = '/logout/' +LOGOUT_REDIRECT_URL = '/' # Update Cache with task progress password diff --git a/rowsandall_app/urls.py b/rowsandall_app/urls.py index f129a657..66771e86 100644 --- a/rowsandall_app/urls.py +++ b/rowsandall_app/urls.py @@ -59,7 +59,9 @@ urlpatterns += [ url(r'^api-auth/', include('rest_framework.urls', namespace='rest_framework')), url(r'^$',rootview), url(r'^login/',auth_views.login, name='login'), - url(r'^logout/',auth_views.logout_then_login,name='logout'), + url(r'^logout/$',auth_views.logout, + {'next_page': '/'}, + name='logout',), url(r'^rowers/',include('rowers.urls')), url(r'^cvkbrno/',include('cvkbrno.urls')), url(r'^admin/rq/',include('django_rq_dashboard.urls')), diff --git a/templates/basebase.html b/templates/basebase.html index 855c26fe..e3a1b755 100644 --- a/templates/basebase.html +++ b/templates/basebase.html @@ -144,7 +144,7 @@
{% if user.is_authenticated %} -

logout

+

logout

{% else %}

 

{% endif %} From c5b0351153cdd3d28f267f0d38c9f30bf4f30b7b Mon Sep 17 00:00:00 2001 From: Sander Roosendaal Date: Tue, 10 Jul 2018 14:56:31 +0200 Subject: [PATCH 4/4] checking for isfinite in normw, normv calc --- rowers/tasks.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/rowers/tasks.py b/rowers/tasks.py index 67d9ee86..420594bd 100644 --- a/rowers/tasks.py +++ b/rowers/tasks.py @@ -619,10 +619,10 @@ def handle_calctrimp(id, normw = 0 - if np.isnan(normv): + if not np.isfinite(normv): normv = 500./120. - if np.isnan(normw): + if not np.isfinite(normw): normw = 0 query = 'UPDATE rowers_workout SET rscore = {tss}, normp = {normp}, trimp={trimp}, hrtss={hrtss}, normv={normv}, normw={normw} WHERE id={id}'.format(